Checks and fixes for pasting copied reference fields#103
Open
Logyrac wants to merge 2 commits into
Open
Conversation
…ing compatibility.
Author
|
Added support for pasting null values to the checks. When null is copied paste menu item will display warning that it will be set to null. If pasting null should be disallowed this is an easy change to revert. On a separate note, it seems that most PRs recently are failing checks, the runner says the UNITY_LICENSE or UNITY_SERIAL secrets are unavailable. This is a safety restriction with GitHub and actions running on pull request, they can't access the secrets of either the source or target repository to prevent actions from potentially leaking that data, but this does throw a wrench in game-ci's builder and test runner. PRs seemed to be working before so not sure what changed, as it stands right now the tests can't be ran reliably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When copying and pasting values from a property's context menu, there were currently no checks in place to avoid certain issues:
JsonUtility.FromJsonOverwriteAdded logic to check for potential conflicts and handle them.
Changes made
SessionStatefor use in type safety comparisonsTypeCandiateService[which is mis-spelled as a note, should be Candidate]) then disable the menu item with message explaining incompatible type.TypeCandiateService, which evaluates theintrinsicTypePolicyandtypeCompatibilityPolicy, for use in testing field combability in pasting, so that theTypeCandiateServiceis a single point of truth on this test.