TDFC cleanup follow up#14111
Merged
xenohedron merged 7 commits intomagefree:masterfrom Jan 13, 2026
Merged
Conversation
* still used by meld, will be removed after converting meld cards
…ckMissingCardData
JayDi85
reviewed
Dec 7, 2025
| filter2.add(Predicates.not(SubType.DINOSAUR.getPredicate())); | ||
| filter2.add(Predicates.not(SubType.VEHICLE.getPredicate())); | ||
| filter2.add(Predicates.or(new AbilityPredicate(TransformAbility.class), TransformedPredicate.instance)); | ||
| filter2.add(TransformablePredicate.instance); |
Member
Contributor
Author
Contributor
There was a problem hiding this comment.
The actual card is silver bordered and the existing implementation is bogus anyway because it isn't something that can be well defined in the rules. So not important for this PR.
xenohedron
approved these changes
Dec 15, 2025
Contributor
xenohedron
left a comment
There was a problem hiding this comment.
I don't see any issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is some additional cleanup for the transforming double faced card rework.
secondSideCardClazzused by old transforming cardsTransformAbilitysince not needed anymoreTODOitemsVALUE_KEY_ENTER_TRANSFORMEDto TransformingDoubleFacedCardPlayer.moveCardsand kept inZonesHandler. Doesn't seem necessary to have redundant check.Mycosynth LatticeandPainter's ServantPermanantCardinitpart of #14099