Completed

Gemfile

@@ -1,6 +1,6 @@
 source "https://rubygems.org"
 
-ruby '2.5.0'
+ruby '2.6.3'
 
 gem "rspec"
 gem "pry"

Gemfile.lock

@@ -29,7 +29,7 @@ DEPENDENCIES
   rspec
 
 RUBY VERSION
-   ruby 2.5.0p0
+   ruby 2.6.3p62
 
 BUNDLED WITH
-   1.16.1
+   1.17.3

lib/questions.rb

@@ -1,58 +1,88 @@
 # round up a float up and convert it to an Integer,
 # so 3.214 becomes 4
 def round_up_number(float)
+  float.ceil
 end
 
 # round down a float up and convert it to an Integer,
 # so 9.52 becomes 9
 def round_down_number(float)
+  float.floor
 end
 
 
 # turn a positive integer into a negative integer. A negative integer
 # stays negative
 def make_numbers_negative(number)
+  -number.abs
 end
 
 # swap the keys and values in a hash. e.g.
 # {'a' => 'b', 'c' => 'd'} becomes
 # {'b' => 'a', 'd' => 'c'}
 def swap_keys_and_values_in_a_hash(hash)
+  hash.invert
 end
 
 # in a hash where the keys and values are all numbers
 # add all the keys and all the values together, e.g.
 # {1 => 1, 2 => 2} becomes 6
 def add_together_keys_and_values(hash)
+  total = 0
+  hash.each do |key, value|
+    total += key + value
+  end
+
+  total
 end
 
 # turn an array (with an even number of elements) into a hash, by
 # pairing up elements. e.g. ['a', 'b', 'c', 'd'] becomes
 # {'a' => 'b', 'c' => 'd'}
 def convert_array_to_a_hash(array)
+  hash = Hash.new
+
+  for i in (0...array.length).step 2 do
+    key = array[i]
+    value = array[i + 1]
+
+    hash[key] = value
+  end
+
+  hash
 end
 
 
 # take out all the capital letters from a string
 # so 'Hello JohnDoe' becomes 'ello ohnoe'
 def remove_capital_letters_from_string(string)
+  upper_case_filter = /[[:upper:]]/
+
+  string.gsub(upper_case_filter, '')
 end
 
 
 # cut strings in half, and return the first half, e.g.
 # 'banana' becomes 'ban'. If the string is an odd number of letters
 # round up - so 'apple' becomes 'app'
 def get_first_half_of_string(string)
+  halfway = round_up_number(string.length.to_f / 2)
+
+  string[0, halfway]
 end
 
 # convert a symbol into a string
 def turn_symbol_into_string(symbol)
+  symbol.to_s
 end
 
 
 # get the domain name *without* the .com part, from an email address
 # so [email protected] becomes makersacademy
 def get_domain_name_from_email_address(email)
+  full_domain = email.partition("@").last
+
+  full_domain.partition(".").first
 end
 
 # capitalize the first letter in each word of a string,
@@ -61,96 +91,186 @@ def get_domain_name_from_email_address(email)
 # 'the lion the witch and the wardrobe' becomes
 # 'The Lion the Witch and the Wardrobe'
 def titleize_a_string(string)
+  word_separator = " "
+  words = string.split(word_separator)
+
+  exceptions = %w(a and the)
+
+  words.each_with_index do |word, index|
+    is_first_word = index == 0
+    is_excepted = exceptions.include? word
+
+    if (!is_excepted) or (is_excepted && is_first_word)
+      words[index] = word.capitalize
+    end
+  end
+
+  words.join(word_separator)
 end
 
 # return true if a string contains any special characters
 # where 'special character' means anything apart from the letters
 # a-z (uppercase and lower) or numbers
 def check_a_string_for_special_characters(string)
+  non_alphanumeric_filter = /\W/
+
+  string.each_char do |char|
+    if char =~ non_alphanumeric_filter
+      return true
+    end
+  end
+
+  false
 end
 
 # keep only the elements that start with an a
 def select_elements_starting_with_a(array)
+  clean_array = Array.new
+
+  array.each do |el|
+    if el[0] == "a"
+      clean_array.push el
+    end
+  end
+
+  clean_array
 end
 
 # keep only the elements that start with a vowel
 def select_elements_starting_with_vowel(array)
+  clean_array = Array.new
+  vowels = %w(a e i o u)
+
+  array.each do |el|
+    if vowels.include? el[0].downcase
+      clean_array.push el
+    end
+  end
+
+  clean_array.join(" ")
 end
 
 
 # remove instances of nil (but NOT false) from an array
 def remove_nils_from_array(array)
+  array.reject { |x| x == nil }
 end
 
 # remove instances of nil AND false from an array
 def remove_nils_and_false_from_array(array)
+  array.reject { |x| !x || x == nil }
 end
 
 # don't reverse the array, but reverse every word inside it. e.g.
 # ['dog', 'monkey'] becomes ['god', 'yeknom']
 def reverse_every_element_in_array(array)
+  reversed_array = Array.new
+
+  array.each do |el|
+    reversed_array.push el.chars.reverse.join
+  end
+
+  reversed_array
 end
 
 # discard the first 3 elements of an array,
 # e.g. [1, 2, 3, 4, 5, 6] becomes [4, 5, 6]
 def all_elements_except_first_3(array)
+  array[3..array.length]
 end
 
 # add an element to the beginning of an array
 def add_element_to_beginning_of_array(array, element)
+  array.prepend element
 end
 
 # return the shortest word in an array
 def shortest_word_in_array(array)
+  array.min_by(&:length)
 end
 
 # return the shortest word in an array
 def longest_word_in_array(array)
+  array.max_by(&:length)
 end
 
 # add up all the numbers in an array, so [1, 3, 5, 6]
 # returns 15
 def total_of_array(array)
+  total = 0
+
+  array.each do |num|
+    total += num
+  end
+
+  total
 end
 
 # get the average from an array, rounded to the nearest integer
 # so [10, 15, 25] should return 17
 def average_of_array(array)
+  (total_of_array(array).to_f / array.length).round
 end
 
 # get all the elements in an array, up until the first element
 # which is greater than five. e.g.
 # [1, 3, 5, 4, 1, 2, 6, 2, 1, 3, 7]
 # becomes [1, 3, 5, 4, 1, 2]
 def get_elements_until_greater_than_five(array)
+  short_numbers = Array.new
+
+  array.each do |num|
+    if num > 5
+      break
+    else
+      short_numbers.push num
+    end
+  end
+
+  short_numbers
 end
 
 # get all the letters used in an array of words and return
 # it as a array of letters, in alphabetical order
 # . e.g. the array ['cat', 'dog', 'fish'] becomes
 # ['a', 'c', 'd', 'f', 'g', 'h', 'i', 'o', 's', 't']
 def get_all_letters_in_array_of_words(array)
+  characters = Array.new
+
+  array.each do |word|
+    puts word
+    word.each_char do |char|
+      puts char
+      characters.push char
+    end
+  end
+
+  characters.sort { |a, b| a <=> b }
 end
 
 # BONUS SECTION
 
 # take a date and format it like dd/mm/yyyy, so Halloween 2013
 # becomes 31/10/2013
 def format_date_nicely(date)
+  date.strftime("%d/%m/%Y")
 end
 
 # get the upper limit of a range. e.g. for the range 1..20, you
 # should return 20
 def get_upper_limit_of(range)
+  range.max
 end
 
 # should return true for a 3 dot range like 1...20, false for a
 # normal 2 dot range
 def is_a_3_dot_range?(range)
+  range.max < range.last
 end
 
 # get the square root of a number
 def square_root_of(number)
+  Math.sqrt number
 end
 
 # --- tougher ones ---
@@ -159,23 +279,59 @@ def square_root_of(number)
 # called call_method_from_string('foobar')
 # the method foobar should be invoked
 def call_method_from_string(str_method)
+  eval(str_method)
 end
 
-# return true if the date is a uk bank holiday for 2014
+# return true if the date is a uk bank holiday for 2018
 # the list of bank holidays is here:
 # https://www.gov.uk/bank-holidays
 def is_a_2018_bank_holiday?(date)
+  bank_holidays = [
+                     Time.new(2018, 1, 1),
+                     Time.new(2018, 3, 30),
+                     Time.new(2018, 4, 2),
+                     Time.new(2018, 5, 7),
+                     Time.new(2018, 5, 28),
+                     Time.new(2018, 8, 27),
+                     Time.new(2018, 12, 25),
+                     Time.new(2018, 12, 26)]
+
+  bank_holidays.include? date
 end
 
 # given your birthday this year, this method tells you
 # the next year when your birthday will fall on a friday
 # e.g. january 1st, will next be a friday in 2016
 # return the day as a capitalized string like 'Friday'
 def your_birthday_is_on_a_friday_in_the_year(birthday)
+  year = birthday.year + 1
+
+  year_found = nil
+
+  while year_found == nil do
+
+    future_birthday = Time.new(year, birthday.month, birthday.day)
+
+    if future_birthday.strftime("%A") == "Friday"
+      year_found = future_birthday.year
+    else
+      year += 1
+    end
+
+  end
+
+  year_found
 end
 
 # count the number of words in a file
 def word_count_a_file(file_path)
+  total_word_count = 0
+
+  File.open(file_path).each_line do |line|
+    total_word_count += line.split(" ").size
+  end
+
+  total_word_count
 end
 
 
@@ -185,4 +341,22 @@ def word_count_a_file(file_path)
 # and 1 that is 4 letters long. Return it as a hash in the format
 # word_length => count, e.g. {2 => 1, 3 => 5, 4 => 1}
 def count_words_of_each_length_in_a_file(file_path)
+  word_lengths = Hash.new
+
+  # remove all non alphabetic and non spaces
+  f = File.read(file_path).gsub(/[^0-9a-z ]/i, '')
+
+  f.each_line do |line|
+
+    line.split(" ").each do |word|
+      if word_lengths.key? word.length
+        word_lengths[word.length] += 1
+      else
+        word_lengths[word.length] = 1
+      end
+    end
+
+  end
+
+  word_lengths
 end

spec/questions_spec.rb

@@ -192,7 +192,7 @@
 
   it 'your_birthday_is_on_a_friday_in_the_year' do
     n = your_birthday_is_on_a_friday_in_the_year(Time.new(2018, 1, 1))
-    expect(n).to eq 2020
+    expect(n).to eq 2021
   end
 
   it 'word_count_a_file' do