feat: Allow to disable the responsive shrink of Buttons - #11324
Open
mjsarfatti wants to merge 1 commit into
Open
feat: Allow to disable the responsive shrink of Buttons#11324mjsarfatti wants to merge 1 commit into
mjsarfatti wants to merge 1 commit into
Conversation
Action buttons always collapse to an icon button below the `sm` breakpoint
(and <CreateButton> to a FAB below `md`), with no way to opt out short of
reimplementing the buttons. Add a `breakpoint` prop to control the threshold,
or disable the behavior entirely with `breakpoint={false}`. Defaults preserve
the current behavior, and the prop is themable via `RaButton.defaultProps` so
it can be turned off application-wide.
Closes marmelab#8720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8720
Problem
Action buttons always collapse to an icon button below the
smbreakpoint (and to a FAB belowmd), with no way to opt out short of reimplementing the buttons.Solution
Add a
breakpointprop to control the threshold, or disable the behavior entirely withbreakpoint={false}. Defaults preserve the current behavior, and the prop is themable viaRaButton.defaultPropsso it can be turned off application-wide.How To Test
See "Button > Breakpoint" and "CreateButton > Breakpoint" stories.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.