Skip to content

Conversation

@gberenice
Copy link
Member

@gberenice gberenice commented Dec 9, 2025

what

  • Updates the default userdata script to match the default ARM arch.
  • Removes TF registry from Renovate config.

why

  • With the previous configuration ssm-agent upgrade failed:
cloud-init[2035]: Error:
cloud-init[2035]:  Problem: conflicting requests
cloud-init[2035]:   - package amazon-ssm-agent-3.3.3185.0-1.x86_64 from @commandline does not have a compatible architecture
cloud-init[2035]:   - nothing provides config(amazon-ssm-agent) = 3.3.3185.0-1 needed by amazon-ssm-agent-3.3.3185.0-1.x86_64 from @commandline

Summary by CodeRabbit

  • Bug Fixes

    • Updated SSM agent installation to properly support ARM64 architecture systems.
  • Chores

    • Refined infrastructure configuration for improved dependency management handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@gberenice gberenice requested a review from a team as a code owner December 9, 2025 17:02
@gberenice gberenice requested a review from Gowiem December 9, 2025 17:02
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

This pull request updates Terraform configuration across two files. The Renovate configuration removes an explicit Terraform registry URL entry, potentially relying on default registry behavior instead. Additionally, the variables.tf file updates the default user_data script for SSM agent installation to use the ARM64 package instead of AMD64, with corresponding adjustments to the heredoc formatting for better readability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • renovate.json5: Straightforward removal of a registryUrls entry with minimal impact surface
  • variables.tf: User_data script update with architectural package change (AMD64 → ARM64) and heredoc formatting adjustment—verify the architecture change aligns with your infrastructure requirements and test the script execution in target environments

Possibly related PRs

Suggested reviewers

  • oycyc

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: correct arch in userdata' directly and clearly summarizes the main change—updating the SSM agent userdata script to use the correct ARM64 architecture instead of AMD64.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/correct-arch-in-userdata

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d3490f and 1fafb8b.

📒 Files selected for processing (2)
  • .github/renovate.json5 (0 hunks)
  • variables.tf (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/renovate.json5
🧰 Additional context used
📓 Path-based instructions (1)
**/*.tf

⚙️ CodeRabbit configuration file

**/*.tf: You're a Terraform expert who has thoroughly studied all the documentation from Hashicorp https://developer.hashicorp.com/terraform/docs and OpenTofu https://opentofu.org/docs/.
You have a strong grasp of Terraform syntax and prioritize providing accurate and insightful code suggestions.
As a fan of the Cloud Posse / SweetOps ecosystem, you incorporate many of their best practices https://docs.cloudposse.com/best-practices/terraform/ while balancing them with general Terraform guidelines.

Files:

  • variables.tf
🧠 Learnings (1)
📚 Learning: 2024-10-23T18:20:57.022Z
Learnt from: oycyc
Repo: masterpointio/terraform-aws-ssm-agent PR: 28
File: tests/unit.tftest.hcl:34-71
Timestamp: 2024-10-23T18:20:57.022Z
Learning: In the `terraform-aws-ssm-agent` module, the user prefers not to include additional assertions for network and security configurations (e.g., root volume encryption, network interface configurations, and security group associations) in the `verify_launch_template` unit test in `tests/unit.tftest.hcl`.

Applied to files:

  • variables.tf
🔇 Additional comments (1)
variables.tf (1)

53-65: Good alignment of architecture across configuration.

The user_data script correctly references the linux_arm64 package, which aligns with the architecture variable default (line 50) and instance_type default of t4g.nano (line 36). This fixes the cloud-init compatibility issue mentioned in the PR. The heredoc syntax using <<-EOT is also the correct choice for maintaining readable indentation in your Terraform module. The S3 URL points to a valid, actively maintained ARM64 SSM agent package.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

oycyc
oycyc previously approved these changes Dec 9, 2025
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question before we ship!

@gberenice gberenice force-pushed the fix/correct-arch-in-userdata branch from 738cd38 to 002bda7 Compare December 10, 2025 14:45
@gberenice gberenice requested a review from Gowiem December 11, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants