fix: Prevent SQL injection in reservation setting#54
fix: Prevent SQL injection in reservation setting#54max-ostapenko wants to merge 2 commits intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The vulnerability fixed is a potential SQL Injection through the
⚠️ Risk: A malicious user or configuration could inject arbitrary SQL statements using
reservationproperty when prepending theSET @@reservationstatement to queries or preOps.'and;characters which would be executed with the privileges of the script running the queries.🛡️ Solution: Implemented strict regex validation
/^[a-zA-Z0-9\-_/]+$/onreservationproperties viapreprocessConfigto verify that they are safe (only containing alphanumeric characters, hyphens, underscores, and forward slashes) before utilizing them in templates. Throws an error for invalid formats instead of rendering.PR created automatically by Jules for task 11716247562806139373 started by @max-ostapenko