-
Notifications
You must be signed in to change notification settings - Fork 7
Update Gemfile.lock during release #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @horgh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the release workflow by integrating an automatic update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds bundle install to the release script. This is a good change as it ensures the Gemfile.lock is updated to reflect the new version number during the release process. I have one suggestion to improve the script's robustness by adding a check to ensure the bundle command is available before it's used.
| # Update version in Gemfile.lock. | ||
| bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For robustness, it's good practice to verify that a command exists before attempting to execute it. The script already does this for other commands like perl and rake in its pre-flight checks. A similar check should be added for bundle to ensure the script fails early with a clear error message if it's not installed.
While it would be ideal to add this check with the others at the top of the script, placing it here is a valuable improvement.
| # Update version in Gemfile.lock. | |
| bundle install | |
| # Update version in Gemfile.lock. | |
| check_command bundle | |
| bundle install |
caa069e to
151f567
Compare
This ensures CI fails immediately with a clear error if Gemfile.lock is out of sync, rather than silently updating it. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This fixes JRuby CI builds which were failing with BUNDLE_FROZEN=true because the lockfile lacked JRuby-compatible gem variants. Co-Authored-By: Claude Opus 4.5 <[email protected]>
No description provided.