Mono bent complex update of header, and extension of string parsing system#2348
Closed
Mono bent complex update of header, and extension of string parsing system#2348
Conversation
…input in Phonon_simple
…input in Phonon_simple rebase phonon_focusing_fix to be from updated main
…cCode into phonon_focusing_fix
…honon simple comp
…als repetitions of it
Add Test instrument for Be-filter models
Disable nightly test of SNS_ARCS instr
Add hints for alternative mcdisplay visualisation in Jupyter...
Add ILL_H142 using ‘simple comps only'
Fix for nasty double-assignment m=m = m, spotted via mcstas-antlr
Add timers for maximal compile / runtime in mctest
Updated Rubredoxin lau file from @aaronfinke
Roll back to PyQt5/qtpy
Updated Example values following updated Rubredoxin.lau
(May serve as drop-in replacement for instrs - without gravitation-support)
…e_gravity Adapt Guide_m interface -> style of Guide_gravity parameters
McStas Monitor_nD “nexusbins” only in listmode
Adding the ILL SANS instrument 'SAM'
Follow-up to #2387
…als repetitions of it
…dev/McCode into mono_bent_complex_update Merge main into mono_bent_complex_update to ensure that the branch is up to data
Collaborator
Author
|
This PR has been overtaken by #2395 due to the erroneous rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Monochromator_bent_complex is updated regarding the changes to the parameter "plane_of_reflections". This is reflected in updates to the header as well. Other minor beauty changes are performed in the header.
The plane_of_reflection parameter could previously only be a string of planes, delimited by a semicolon between each plane. With this update, the option of having a single plane of reflection for all crystals is added. E.g. a three crystal definition of "Si111;Si111;Si111" can now be defined by "Si111".
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
MacOS Tahoe 26.2
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy contribution includes patches to an existing instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)mctestutility to test the instrument (please attachmcviewtestreport as screenshot in comments)mcrun --c-lint"linter" and followed advice to remove most / all warnings that are raised