Skip to content

Conversation

@mdz
Copy link
Owner

@mdz mdz commented Feb 6, 2026

Fixes #69

SmartTub API returns ECO_MODE for primary filtration on some spas (e.g. J-375). The enum only had NORMAL and NANO_MODE, causing KeyError: 'ECO_MODE' when parsing get_status_full() and breaking the integration after login.

Change: Add ECO_MODE to SpaPrimaryFiltrationCycle.PrimaryFiltrationMode in smarttub/api.py.

Made with Cursor


Note

Low Risk
Small, localized enum expansion that only affects parsing/serialization of primary filtration mode values.

Overview
Adds ECO_MODE to SpaPrimaryFiltrationCycle.PrimaryFiltrationMode so SmartTub responses that report primaryFiltration.mode == "ECO_MODE" can be parsed without raising KeyError (e.g., when calling get_status_full()).

Written by Cursor Bugbot for commit 517848c. This will update automatically on new commits. Configure here.

mdz and others added 2 commits February 5, 2026 21:12
SmartTub API returns ECO_MODE for primary filtration on some spas (e.g. J-375).
Missing enum value caused KeyError when fetching full spa status after login.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mdz mdz merged commit 243bb69 into main Feb 6, 2026
3 checks passed
@mdz mdz deleted the fix-primary-filtration-eco-mode branch February 6, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Access Any Smarttub Info after successful login

1 participant