Add ECO_MODE to PrimaryFiltrationMode enum (fixes #69) #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
SmartTub API returns
ECO_MODEfor primary filtration on some spas (e.g. J-375). The enum only hadNORMALandNANO_MODE, causingKeyError: 'ECO_MODE'when parsingget_status_full()and breaking the integration after login.Change: Add
ECO_MODEtoSpaPrimaryFiltrationCycle.PrimaryFiltrationModeinsmarttub/api.py.Made with Cursor
Note
Low Risk
Small, localized enum expansion that only affects parsing/serialization of primary filtration mode values.
Overview
Adds
ECO_MODEtoSpaPrimaryFiltrationCycle.PrimaryFiltrationModeso SmartTub responses that reportprimaryFiltration.mode == "ECO_MODE"can be parsed without raisingKeyError(e.g., when callingget_status_full()).Written by Cursor Bugbot for commit 517848c. This will update automatically on new commits. Configure here.