Open
Conversation
also remove the old version of the subch inputs
Temperature was 0, causing tempi to be infinity during the eos call. I'm able to run wdmerger to the step # 3.
they are now `constexpr`
cellsize is not set at this point. So manually set it here.
…d of amrex (#3048) This pr adds explicit evaluation of the thermal diffusion source term in castro, without needing to use amrex. In particular, this seems to work well for 2D spherical geometry.
…t test (#3047) this pr adds problem_bc_fill.H, which allows to use inflow, i.e. Dirichlet, boundary condition by using the analytic solution for different problems. Even though this is intended to use for spherical 2d input file, but any input file theoretically can use this as long as its constant conductivity.
we had a ** due to line wrapping
* dataset processing can run in parallel * added code to make interactive plots of each dataset that show the raw slice data, the averaged profile, and the positions for each metric * metric thresholds are calculated using both the local maximum and global maximum at the same time (under <field>[<fac>%] and <field>[<fac>%]_gmax, respectively) * the local maximum for each field is stored in the output file, in the max_<field> column * if a field value never goes below the threshold for a metric, its position will be stored as NaN * --[xyz]lim arguments now work, despite some yt bugs * allow ignoring plotfiles after a certain time with --tmax * default FRB resolution is set to match the finest level, and is automatically adjusted if custom limits are used
…ffusion test (#3054) Updates problem_bc_fill to do either face-centered or cell centered depending on where castro.diffuse_use_amrex_mlmg is used. Gets 2nd order accuracy (with L-inf error) with max_level=0 for 2d spherica To test theta dependence, the analytic solution of spherical-bessel function and legendre polynomial is used. Currently only castro evaluation works. Also added an 2d spherical input file for noncenter Gaussian, a convergence test for this still needs to be done in the future.
if we mistakenly target "main" and then switch to "development", then check-ifdefs, codespell, and docs never run. This changes the action to look like the others so these should hopefully run.
some of the inputs were redudant also renamed a few updated the README.md finally added a dt option to the profiles.py script
we fill this in Microphysics, but it was not being captured in job_info
* 1D inputs and new model * update README * update 1d lower boundary
r is the reduction parameter but we were also using it in the reduction loop for the radius (for 2D spherical)
also disable a new check
…3061) this shows the mass fractions behind the detonation
add papers
we can't to .ptp() anymore, but instead should use np.ptp()
some loop counters were also uninitialized. this also fixes a few compiler warnings.
also remove some old inputs files
fix color contrast add back link underlining
fix color contrast add back link underlining
also some tests don't need "fetch-depth: 0" Co-authored-by: Zhi Chen <62574124+zhichen3@users.noreply.github.com>
in particular, the make flags and CUDA version
this is pointed out by #3216
Co-authored-by: Max Katz <maxpkatz@gmail.com>
Fix always true assert pointed out in #3209. The sign issue is done this way on purpose to achieve reflection boundary condition on 0 and pi. I added more comment to explain.
guard off a transverse part if we are not >= 2D fix +Z BC check
also rewrite another instance to be clear that we are working on rho X
point mass is no longer enabled at compile time. This pr updates the doc to reflect that. Also add docs about point_mass_offset_is_true and point_mass_location_offset.
we were resetting it each loop iteration. The new-gravity version was already done correctly.
we are 1-based, so failure means i > max_iters
if we bailed on an attempt with nsub sub-intervals, then we never reset the starting state to U^n for the attempt with 2*nsub intervals.
we were not using the dx on the current level
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3284) we should use ltime, which is correctly set depending on the value of `post_step_regrid`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.