nrf52: allow companion to sleep when idle#1682
Open
oltaco wants to merge 1 commit intomeshcore-dev:devfrom
Open
nrf52: allow companion to sleep when idle#1682oltaco wants to merge 1 commit intomeshcore-dev:devfrom
oltaco wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
oltaco
force-pushed
the
nrf52-lowpower
branch
from
d4e348a to
8bf09b4
Compare
Contributor
Author
|
Forgot to remove some commented testing code, fixed now. 🤦♂️ |
weebl2000
reviewed
Feb 13, 2026
| rtc_clock.tick(); | ||
|
|
||
| #if defined(NRF52_PLATFORM) | ||
| board.sleep(1800); |
Contributor
There was a problem hiding this comment.
Suggested change
| board.sleep(1800); | |
| if (!the_mesh.hasPendingWork()) { | |
| board.sleep(1800); | |
| } |
Maybe?
Probably need to add hasPendingWork(), _mgr->getOutboundCount(0xFFFFFFFF) > 0 - not sure if it's actually useful.
|
I have a WioTracker L1, put up a test bin and I can check this in my lab and report back. |
Contributor
Build it here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from the NRF52 repeater power savings, this adds the same for NRF52 companions.
I've been running it on WioTrackerL1/ThinkNode M1/Heltec T114/Meshtiny for the last week with no issues.