sensecap_solar: Simple fix LED definitions#1689
Open
Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Open
sensecap_solar: Simple fix LED definitions#1689Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the LED pin definitions for the SenseCap Solar P1 to match the actual hardware. The blue LoRa TX LED was incorrectly named green in the code, and the user LED is white (not blue).
Problem
LED_GREENon pin 12LED_BLUEon pin 11Changes
LED_GREEN(12) →LED_WHITE(11) – User LED on D11LED_BLUE(11) →LED_BLUE(12) – LoRa TX indicator on D12Hardware mapping
LED_WHITELED_BLUE