Conversation
lewurm
added a commit
to lewurm/monors
that referenced
this pull request
Feb 22, 2018
contribution found at michaelliao/githubpy#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am suggesting a small improvement to the situation described in #7 to make the commits api usable:
Basically, instead of a list, a list-like object with an all() method is returned. The all() method is a method yielding (i.e. it is a generator) all items of the current and following pages. Note that this method is not applicable to the search api as it returns a dictionary that contains the item list (https://developer.github.com/v3/search/)