Remove non-header files from include folder #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `include` directory previously contained all files copied over, but only `*.h` and `*.hpp` files are required. This commit removes all files that do not have a `.h` or `.hpp` extension, as well as any empty directories that may result from this cleanup. Signed-off-by: Meet Gandhi <[email protected]>
Contributor
Author
|
@pablogs9 any updates on this? |
Member
|
Reopening to have CI passing |
Member
|
@mergify backport rolling jazzy |
Contributor
✅ Backports have been createdDetails
|
Member
|
@meetgandhi-dev thanks for the contrib! |
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
The `include` directory previously contained all files copied over, but only `*.h` and `*.hpp` files are required. This commit removes all files that do not have a `.h` or `.hpp` extension, as well as any empty directories that may result from this cleanup. Signed-off-by: Meet Gandhi <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> (cherry picked from commit 096ded0)
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
The `include` directory previously contained all files copied over, but only `*.h` and `*.hpp` files are required. This commit removes all files that do not have a `.h` or `.hpp` extension, as well as any empty directories that may result from this cleanup. Signed-off-by: Meet Gandhi <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> (cherry picked from commit 096ded0)
This was referenced Dec 9, 2024
pablogs9
added a commit
that referenced
this pull request
Dec 9, 2024
* Remove non-header files from include folder (#716) The `include` directory previously contained all files copied over, but only `*.h` and `*.hpp` files are required. This commit removes all files that do not have a `.h` or `.hpp` extension, as well as any empty directories that may result from this cleanup. Signed-off-by: Meet Gandhi <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> (cherry picked from commit 096ded0) * Fix CI Signed-off-by: Pablo Garrido <[email protected]> * Fix naming * Ensure naming * New line fix --------- Signed-off-by: Pablo Garrido <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>
pablogs9
added a commit
that referenced
this pull request
Dec 9, 2024
* Remove non-header files from include folder (#716) The `include` directory previously contained all files copied over, but only `*.h` and `*.hpp` files are required. This commit removes all files that do not have a `.h` or `.hpp` extension, as well as any empty directories that may result from this cleanup. Signed-off-by: Meet Gandhi <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> (cherry picked from commit 096ded0) * Fix CI Signed-off-by: Pablo Garrido <[email protected]> * Fix naming * Ensure naming * New line fix --------- Signed-off-by: Pablo Garrido <[email protected]> Co-authored-by: Meet Gandhi <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
includedirectory previously contained all files copied over, but only*.hand*.hppfiles are required. This commit removes all files that do not have a.hor.hppextension, as well as any empty directories that may result from this cleanup.