fix(connectors): return error for malformed Keycloak config response#396
Closed
hazelmayank wants to merge 1 commit into
Closed
fix(connectors): return error for malformed Keycloak config response#396hazelmayank wants to merge 1 commit into
hazelmayank wants to merge 1 commit into
Conversation
Signed-off-by: hazelmayank <mayankjeefinal@gmail.com>
|
duplicate #267 rubrx filed the same panic issue earlier , root issue is already tracked |
Contributor
Author
|
Sorry I forgot to check if the same issue was addressed before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
GetKeycloakURLdefensive when parsing the/api/keycloak/configresponse.Previously, the function used direct type assertions for fields like
enabled,auth-server-url, andrealm. If the server returned a malformed or unexpected response, the CLI could panic with an interface conversion error instead of returning a normal error.This PR replaces those assertions with comma-ok checks and returns descriptive errors for malformed responses.
Why
This improves CLI reliability at the connector/API layer. Commands that communicate with a Microcks server should return clean errors instead of crashing on unexpected server responses.
What changed
enabledauth-server-urlrealmTest plan
go test -v -run TestGetKeycloakURL ./pkg/connectors/...go test ./pkg/connectors/...go build ./...Note:
go test ./...may still show the existingTestDeleteContextfailure on master, which is unrelated to this PR and fixed separately in #334.Closes #395