fix(connectors): replace panics with error returns and add HTTP status code validation#402
Open
gyanranjanpanda wants to merge 1 commit into
Open
Conversation
gyanranjanpanda
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
…s code validation Replace panic() calls with proper error returns and add HTTP response status code validation in all API client methods that previously crashed on non-2xx responses. Changes: - GetKeycloakURL: add status check, replace panics, guard type assertions - CreateTestResult: add status check, replace panics, guard id assertion - GetTestResult: add status check, replace panic (prevents silent false failures) - DownloadArtifact: replace remaining ReadAll panic - ConnectAndGetToken: add status check, replace panics, guard assertion - GetOIDCConfig: add status check, replace panics, guard assertions, fix swallowed error - ConnectAndGetTokenAndRefreshToken: add status check, replace panics, guard assertions, fix swallowed error Fixes microcks#401 Signed-off-by: gyanranjanpanda <sanupanda141@gmail.com>
gyanranjanpanda
force-pushed
the
fix/non-2xx-response-panic-401
branch
from
0126144 to
d1a15b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #401 - Six methods across
pkg/connectors/microcks_client.goandpkg/connectors/keycloak_client.gopreviously crashed with Go panics when receiving non-2xx HTTP responses. This PR replaces allpanic()calls with proper error returns and adds HTTP status code validation before JSON parsing.Changes
pkg/connectors/microcks_client.gopkg/connectors/keycloak_client.goTests (18 new)
microcks_client_error_test.go: 16 tests for non-2xx, malformed JSON, missing fields, disabled Keycloak, redeemRefreshToken.keycloak_client_test.go: 7 tests covering all Keycloak client error paths.