fix(config): return pointers to slice elements in LocalConfig getters#407
Open
Rahulatram321 wants to merge 3 commits into
Open
fix(config): return pointers to slice elements in LocalConfig getters#407Rahulatram321 wants to merge 3 commits into
Rahulatram321 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes pointer semantics in
LocalConfiggetters to ensure returned pointers reference real backing slice elements.Problem
The getters used range-value iteration patterns like:
for _, u := range l.Users { return &u }This returns the address of a loop variable copy, not the original slice element.
As a result, callers mutating through returned pointers may silently modify detached copies, causing subtle state bugs.
Changes
Updated all affected getters in
pkg/config/localconfig.goto index-based iteration:GetUserGetServerGetInstanceGetAuthPattern changed to:
for i := range l.Users { return &l.Users[i] }(and equivalent for other slices)Tests
Added
pkg/config/localconfig_test.gowith regression coverage that verifies pointer-backed mutation for all four getters:Result
LocalConfigslices.