Add powershell (windows) support#238
Conversation
|
@microsoft-github-policy-service agree |
|
Thank you for this contribution, @cnukaus! 🎉 Adding Codex CLI support and fixing the Windows The |
Alan-Jowett
left a comment
There was a problem hiding this comment.
Thanks again for this well-structured PR! A few items to address before merge:
IMPLEMENTATION_PLAN.md — please remove (must fix)
This appears to be a development log from the implementation process. PromptKit doesn't maintain implementation plans at the repo root, and this would add noise to the project structure.
Spec files need codex added (should fix):
requirements.md has several references to the supported CLI list that need codex added:
- REQ-CLI-010 — detection order (
copilot → gh copilot → claude) - REQ-CLI-011 — valid
--clivalues (copilot, gh-copilot, claude) - REQ-CLI-017 — per-CLI spawn commands (missing codex entry)
- ASSUMPTION-003 — accepted
--clivalues
validation.md should document the new TC-CLI-072A test case alongside existing TC-CLI-072.
|
Updated routing .cmd launches through cmd.exe in cli/lib/launch.js:67 while keeping The No supported LLM CLI found on PATH lines are still expected from the negative-path tests. The important part is that the spawn EINVAL should now be gone. |
|
Hi @cnukaus / @what-cloud — thanks for the follow-up commits! A few items still need attention before we can merge:
Everything else looks good — the spec updates for codex, the test fixes, and the Windows |
|
PR microsoft#238 introduced encoding corruption where em-dash characters (—) were replaced with ??? in four locations in launch.test.js. This restores the original Unicode em-dash (U+2014) characters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR #238 introduced encoding corruption where em-dash characters (—) were replaced with ??? in four locations in launch.test.js. This restores the original Unicode em-dash (U+2014) characters. Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enhanced Powershell support:
I added Windows command resolution helpers, added
codexdetection, expanded the “no CLI found” message to include Codex, and changed npm-installed CLIs to prefer<name>.cmdon Windows before spawning.That fixes the exact failure mode where PowerShell can run
codexbutchild_process.spawn(\"codex\")cannot.I also updated the CLI surface and docs, now advertises
codexin--cli