Scorer composition (PR C, 3/3): complete LLM rollout with typed rubrics#2157
Merged
romanlutz merged 10 commits intoJul 12, 2026
Merged
Conversation
Migrate the remaining LLM-based scorers off the transitional Scorer._score_value_with_llm_async forwarder to the pure v1.0 composition API and delete the base forwarder. Each scorer now stores chat_target + system_prompt + response_handler and calls _run_llm_scoring_async directly. Scorers migrated: - SelfAskQuestionAnswerScorer - SelfAskRefusalScorer - SelfAskCategoryScorer - SelfAskGeneralTrueFalseScorer - SelfAskScaleScorer - SelfAskLikertScorer - SelfAskGeneralFloatScaleScorer - InsecureCodeScorer Float-scale scorers bake numeric_value=True into the default JsonSchemaResponseHandler; identifiers read response_handler.response_schema. Preset construction moves to from_* factories (from_scale_arguments, from_likert_scale, from_content_classifier, from_question) with module-level render_*_system_prompt and load_scale_arguments helpers. Also migrate first-party consumers off the removed legacy constructors: crescendo, tree_of_attacks, fairness_bias (docstring example), fuzzer, and the scorer initializer registrations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Can you link you design gist? (update: found it, but it is convenient to have here :)) |
rlundeen2
reviewed
Jul 10, 2026
rlundeen2
reviewed
Jul 10, 2026
rlundeen2
reviewed
Jul 10, 2026
rlundeen2
approved these changes
Jul 10, 2026
Covers chat_target=None guards, system_prompt str/invalid-type resolution, likert/scale/category system-prompt assembly validation, and refusal score_category normalization across the 7 migrated LLM scorers so diff-cover clears the 90 percent gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate all doc notebooks that constructed LLM scorers via the legacy keyword API (SelfAskTrueFalseScorer(true_false_question=...), SelfAskLikertScorer(likert_scale=...), SelfAskCategoryScorer(content_classifier_path=...)) to the new composition classmethods (from_question / from_likert_scale / from_content_classifier, with TrueFalseQuestion.from_yaml for path-based questions). Both paired .py and .ipynb files updated in sync. Freshly re-executed the core scorer/target notebooks (scoring/1, scoring/2, scoring/4, targets/1) to validate the new API end-to-end and refresh outputs. Remaining notebooks are code-migrated with preserved outputs (they require infra/targets not available in this environment). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Freshly re-ran executor/3_attack_configuration, executor/6_benchmark, executor/7_promptgen, targets/3_openai_image_target, and targets/round_robin_target to refresh outputs under the migrated scorer API. Normalized memory image paths in the image-target notebook to the repo-standard ./dbdata/ form. The Sora video notebook (targets/4) requires video-generation access unavailable here (execution aborted, left code-migrated). executor/8_modality_feedback executed successfully but was left at its code-migrated outputs to avoid a +7MB notebook-size increase. The 5 hard-infra notebooks (multi_turn, realtime, playwright, http, azure_sql) remain code-migrated with preserved outputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
Render scorer prompts and runtime configuration from shared immutable rubric objects, and validate classifier and Likert responses against those contracts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
Resolve the scorer test conflict against the composition helper and retain the merged Crescendo scorer factory migration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
Refresh paired Jupytext metadata after merging the latest main branch so all changed notebooks remain synchronized. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5ae1b829-e7b8-45e7-825b-500377557df1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design: Scorer architecture refactor design gist
Final PR (3/3) of the scorer-architecture refactor ("Option 5 - scorer-owned composition"), following #2125 (
ResponseHandler+ internal round-trip helper) and #2146 (TrueFalse pure-composition API +CallableResponseHandler), both now merged tomain.This rolls the pure v1.0 composition API out to the remaining LLM-based scorers and removes the last transitional forwarder. Each migrated scorer owns its target, prompt configuration, and
ResponseHandler, then calls_run_llm_scoring_async(...)directly instead of the deletedScorer._score_value_with_llm_asyncbase-class forwarder.The final API also introduces typed rubric/configuration objects. Factory methods render the LLM prompt and configure runtime validation, categories, and normalization from the same object, preventing hidden defaults from drifting away from prompt content. Direct custom construction requires the final prompt together with its rubric/configuration.
Scorers migrated
SelfAskQuestionAnswerScorerSelfAskRefusalScorerSelfAskCategoryScorerSelfAskGeneralTrueFalseScorerSelfAskScaleScorerSelfAskLikertScorerSelfAskGeneralFloatScaleScorerInsecureCodeScorerFinal composition API
SelfAskScaleScorer.from_scale(...)uses aNumericRubric; prompt rendering, category, and normalization bounds come from that rubric. Omitting it retains the bundled tree-of-attacks rubric.SelfAskLikertScorer.from_likert_scale(...)uses an immutableLikertScale; configured entries define prompt text, valid returned levels, category, bounds, and normalization.SelfAskGeneralFloatScaleScorerrequires aNumericRangefor explicit normalization bounds and optional category.SelfAskCategoryScorer.from_content_classifier(...)uses aContentClassifier; configured categories and boolean relationships are validated inside the retry boundary.SelfAskTrueFalseScorer.from_question(...)renders from aTrueFalseQuestion; custom direct construction requires both prompt and question, while omitting both retains the bundled default.InsecureCodeScorer.from_harm_categories(...)uses the same immutable category snapshot for prompt rendering and score metadata.SeedPromptinstances, or inline Jinja strings where supported. Module-levelrender_*_system_prompthelpers expose rendering without constructing a scorer.Other details
numeric_value=Trueon their defaultJsonSchemaResponseHandler. Embedded response schemas flow through the default handler; caller-supplied handlers continue to own their own response contract..py/.ipynbrepresentations.Breaking changes (v1.0)
Legacy path-based constructor arguments and transitional helpers are removed in favor of explicit composition constructors and
from_*factories. Notably,from_scale_arguments/load_scale_argumentsare replaced byfrom_scale(...)withNumericRubric; the minimal normalization type isNumericRange. No deprecation shims remain.Testing
tychecks pass