Skip to content

Conversation

@Mohitlikestocode
Copy link

What does this PR do?

Fixes incorrect MDN reference links for the animation frame APIs in baselines/dom.generated.d.ts.
Fixes #2154

What was wrong?

The JSDoc MDN references for:

  • requestAnimationFrame
  • cancelAnimationFrame

were pointing to the DedicatedWorkerGlobalScope MDN pages, which is misleading when using these APIs as standard Window globals (e.g. window.requestAnimationFrame(...), window.cancelAnimationFrame(...)).

What changed?

Updated the MDN reference URLs to the correct Window pages:

  • https://developer.mozilla.org/docs/Web/API/Window/requestAnimationFrame
  • https://developer.mozilla.org/docs/Web/API/Window/cancelAnimationFrame

Impact

This is a documentation/reference-only change:

  • ✅ improves IntelliSense / hover tooltips
  • ✅ no type signature changes
  • ✅ no runtime behavior changes

Copilot AI review requested due to automatic review settings January 25, 2026 12:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Collaborator

Dear cloude code or copilot or whatever AI agent, please don't modify mdn.json, it's written in the doc...

@Mohitlikestocode
Copy link
Author

Hey @saschanaz! Very sorry, I didn’t know inputfiles/mdn.json shouldn’t be modified.

I first edited baselines/dom.generated.d.ts, but CI failed because generator output didn’t match baseline, so I traced the source and ended up changing mdn.json.

Should I instead add an override (e.g. in inputfiles/comments.json) and regenerate the baselines?

@saschanaz
Copy link
Collaborator

This is really MDN issue that duplicates the same documentation for the same global function. I argued in mdn/content#39951 and they dismissed. I think maybe time to argue again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect MDN link for requestAnimationFrame in lib.dom.d.ts

2 participants