Implement Create Container #13758
Draft
Implement Create Container #13758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrivedi
requested review from
OneBlue,
benhillis,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Copilot finished reviewing on behalf of
ptrivedi
November 21, 2025 19:35
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the "Create Container" functionality for WSLA (Windows Subsystem for Linux for Apps), adding comprehensive infrastructure for container management, virtual machine control, and process execution. The implementation introduces a new service (wslaservice), client library (wslaclient), and extensive test coverage.
Key Changes:
- New WSLA service architecture with COM interfaces for session, VM, and container management
- Container creation support via nerdctl integration
- Client API for querying and installing WSL components
- Comprehensive test suite with 1100+ lines covering VM, process, networking, and container scenarios
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/windows/wslaservice/inc/wslaservice.idl | Defines COM interfaces for WSLA service including IWSLASession, IWSLAContainer, IWSLAProcess, and IWSLAVirtualMachine |
| src/windows/wslaservice/exe/WSLAVirtualMachine.cpp | Implements VM lifecycle management, process creation, networking, and disk operations |
| src/windows/wslaservice/exe/WSLAContainer.cpp | Implements container creation using nerdctl with GPU, volume, and port mapping support |
| src/windows/wslaservice/exe/WSLASession.cpp | Implements session management coordinating VM and container operations |
| src/windows/wslaclient/DllMain.cpp | Client library implementation for component installation and version checking |
| test/windows/WSLATests.cpp | Comprehensive test suite covering VM boot, processes, networking, mounts, and GPU features |
| tools/FormatSource.ps1.in | Fixes PowerShell script to handle missing $PSScriptRoot and correct file filtering |
| test/windows/Common.h | Refactors RegistryKeyChange to defer key opening for improved resource management |
| // Constants for required default arguments for "nerdctl run..." | ||
| static std::vector<std::string> defaultNerdctlRunArgs{ | ||
| "--pull=never", | ||
| "--host=net", // TODO: default for now, change later |
There was a problem hiding this comment.
The networking option appears to be incorrect. '--host=net' is not a valid nerdctl option. The correct option should be '--net=host' or '--network=host' for host networking mode.
Suggested change
| "--host=net", // TODO: default for now, change later | |
| "--network=host", // Use correct nerdctl option for host networking |
ptrivedi
force-pushed
the
user/ptrivedi/create-cont
branch
from
1220fbe to
3d5fa8b
Compare
Co-authored-by: Copilot <[email protected]>
…oft/WSL into user/ptrivedi/create-cont
yao-msft
reviewed
Nov 22, 2025
| return wil::MakeOrThrow<WSLAContainer>(&parentVM, launcher.Launch(parentVM)); | ||
| } | ||
|
|
||
| std::vector<std::string> WSLAContainer::prepareNerdctlRunCommand(const WSLA_CONTAINER_OPTIONS& options) |
There was a problem hiding this comment.
nit:
Suggested change
| std::vector<std::string> WSLAContainer::prepareNerdctlRunCommand(const WSLA_CONTAINER_OPTIONS& options) | |
| std::vector<std::string> WSLAContainer::PrepareNerdctlRunCommand(const WSLA_CONTAINER_OPTIONS& options) |
|
|
||
| using wsl::windows::service::wsla::WSLAContainer; | ||
|
|
||
| const std::string nerdctlPath = "/usr/bin/nerdctl"; |
There was a problem hiding this comment.
nit: and similar for below
Suggested change
| const std::string nerdctlPath = "/usr/bin/nerdctl"; | |
| constexpr std::string_view c_nerdctlPath = "/usr/bin/nerdctl"sv; |
Collaborator
There was a problem hiding this comment.
Ended up using a constexpr const char*, since that makes it easier to add to the command line vectors
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.