Fix race condition in the ListenWithoutBindIsTracked test case - #41352
Draft
Blue (OneBlue) wants to merge 4 commits into
Draft
Fix race condition in the ListenWithoutBindIsTracked test case#41352Blue (OneBlue) wants to merge 4 commits into
Blue (OneBlue) wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VerifyListenWithoutBindIsTracked test logic in the WSL Windows network test suite to eliminate a race between host-side bind() retries and the guest-side implicit port binding/tracking, making the test less flaky while still validating that the listen-without-bind scenario becomes reachable from the host.
Changes:
- Keep the guest-side listening socket alive across multiple host connection attempts by accepting connections in a loop.
- Replace the host-side “retry bind until it gets blocked” probe with a “retry connect until it succeeds” probe to avoid competing for the same port.
- Explicitly target loopback (
INADDR_LOOPBACK) for the host connection probe.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a race condition in the tests: We're waiting for GNS to perform a port binding, but we're also calling bind() on the same port on the host. If the GNS bind comes right while we hold the bound socket, it will fail and the test will fail.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed