Python: Fix: Skip model_deployment_name validation for application endpoints (Azure new foundary agents) #3621
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
model_deployment_namevalidation when using application endpoints inAzureAIClient. Azure new foundary agentsProblem
When using
AzureAIClientwith an application endpoint (pre-configured Foundry agent), the framework incorrectly requiresmodel_deployment_nameeven though:modelfield gets stripped fromrun_optionsanyway for application endpoints (lines 404-417)This forces users to provide a dummy/placeholder value like
model_deployment_name="placeholder"which is confusing and unnecessary.Error before fix:
ValueError: model_deployment_name must be a non-empty string
Solution
Added a check in
_check_model_presence()to skip validation when_is_application_endpointisTrue: