-
Notifications
You must be signed in to change notification settings - Fork 2.2k
.NET: Add parallel declarative Foreach execution #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KirschQAQ (KirschBluteX)
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
KirschBluteX:feat/declarative-foreach-parallel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ForeachExecutionOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| using System; | ||
| using System.Globalization; | ||
| using Microsoft.Agents.AI.Workflows.Declarative.Extensions; | ||
| using Microsoft.Agents.ObjectModel; | ||
|
|
||
| namespace Microsoft.Agents.AI.Workflows.Declarative.ObjectModel; | ||
|
|
||
| internal enum ForeachExecutionMode | ||
| { | ||
| Sequential, | ||
| Parallel, | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Strongly typed adapter for Foreach execution fields preserved by the external ObjectModel package. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// Once <see cref="Foreach"/> exposes generated properties for these fields, only this adapter needs to change. | ||
| /// </remarks> | ||
| internal sealed record ForeachExecutionOptions( | ||
| ForeachExecutionMode Mode, | ||
| int MaxParallelism, | ||
| TimeSpan? IterationTimeout) | ||
| { | ||
| internal const string ModePropertyName = "mode"; | ||
| internal const string MaxParallelismPropertyName = "maxParallelism"; | ||
| internal const string TimeoutPropertyName = "timeoutInMilliseconds"; | ||
|
|
||
| private const int DefaultMaxParallelism = 4; | ||
|
|
||
| public bool IsParallel => this.Mode == ForeachExecutionMode.Parallel; | ||
|
|
||
| public static ForeachExecutionOptions Parse(Foreach model) | ||
| { | ||
| DataValue? modeValue = GetExtensionValue(model, ModePropertyName); | ||
| DataValue? maxParallelismValue = GetExtensionValue(model, MaxParallelismPropertyName); | ||
| DataValue? timeoutValue = GetExtensionValue(model, TimeoutPropertyName); | ||
|
|
||
| ForeachExecutionMode mode = ParseMode(model, modeValue); | ||
| int maxParallelism = ParseInteger(model, MaxParallelismPropertyName, maxParallelismValue) ?? DefaultMaxParallelism; | ||
| int? timeoutMilliseconds = ParseInteger(model, TimeoutPropertyName, timeoutValue); | ||
|
|
||
| if (mode == ForeachExecutionMode.Sequential && (maxParallelismValue is not null || timeoutValue is not null)) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{MaxParallelismPropertyName}' and '{TimeoutPropertyName}' require '{ModePropertyName}: Parallel'."); | ||
| } | ||
|
|
||
| if (maxParallelism <= 0) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{MaxParallelismPropertyName}' must be greater than zero."); | ||
| } | ||
|
|
||
| if (timeoutMilliseconds <= 0) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{TimeoutPropertyName}' must be greater than zero when specified."); | ||
| } | ||
|
|
||
| return new(mode, maxParallelism, timeoutMilliseconds.HasValue ? TimeSpan.FromMilliseconds(timeoutMilliseconds.Value) : null); | ||
| } | ||
|
|
||
| private static ForeachExecutionMode ParseMode(Foreach model, DataValue? value) | ||
| { | ||
| if (value is null) | ||
| { | ||
| return ForeachExecutionMode.Sequential; | ||
| } | ||
|
|
||
| if (value is not StringDataValue stringValue) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{ModePropertyName}' must be 'Sequential' or 'Parallel'."); | ||
| } | ||
|
|
||
| if (string.Equals(stringValue.Value, nameof(ForeachExecutionMode.Sequential), StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return ForeachExecutionMode.Sequential; | ||
| } | ||
|
|
||
| if (string.Equals(stringValue.Value, nameof(ForeachExecutionMode.Parallel), StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return ForeachExecutionMode.Parallel; | ||
| } | ||
|
|
||
| throw InvalidConfiguration(model, $"'{ModePropertyName}' must be 'Sequential' or 'Parallel'."); | ||
| } | ||
|
|
||
| private static int? ParseInteger(Foreach model, string propertyName, DataValue? value) | ||
| { | ||
| if (value is null) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| object? rawValue = value.ToFormula().ToObject(); | ||
| if (rawValue is not (byte or sbyte or short or ushort or int or uint or long or ulong or float or double or decimal)) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{propertyName}' must be an integer."); | ||
| } | ||
|
|
||
| decimal decimalValue; | ||
| try | ||
| { | ||
| decimalValue = Convert.ToDecimal(rawValue, CultureInfo.InvariantCulture); | ||
| } | ||
| catch (Exception exception) when (exception is FormatException or InvalidCastException or OverflowException) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{propertyName}' must be an integer.", exception); | ||
| } | ||
|
|
||
| if (decimalValue != decimal.Truncate(decimalValue) || decimalValue < int.MinValue || decimalValue > int.MaxValue) | ||
| { | ||
| throw InvalidConfiguration(model, $"'{propertyName}' must be an integer."); | ||
| } | ||
|
|
||
| return decimal.ToInt32(decimalValue); | ||
| } | ||
|
|
||
| private static DataValue? GetExtensionValue(Foreach model, string propertyName) => | ||
| model.ExtensionData?.Properties.TryGetValue(propertyName, out DataValue? value) is true ? value : null; | ||
|
|
||
| private static DeclarativeModelException InvalidConfiguration(Foreach model, string message, Exception? innerException = null) => | ||
| new($"Invalid Foreach configuration for '{model.Id.Value}': {message}", innerException); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.