Fix JSONDecodeError when tool_call.arguments is empty string in AssistantAgent._execute_tool_call #7128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description
When using Claude models (or other LLM providers) with tool calling, the `tool_call.arguments`
field may be an empty string `""` instead of `"{}"` for tools that don't require parameters.
This causes a `JSONDecodeError[ in ](file://core/mt_llm_client.py#90#24)AssistantAgent._execute_tool_call` method, even though
the tool call is valid and should be executed with empty arguments.
## Current Behavior
```python
# In _assistant_agent.py line 1547
arguments = json.loads(tool_call.arguments) # Raises JSONDecodeError for ""
```
When `tool_call.arguments = ""`, this raises:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Claude models (or other LLM providers) with tool calling, the
tool_call.argumentsfield may be an empty string""instead of"{}"for tools that don't require parameters.This causes a
JSONDecodeError[ in ](file://core/mt_llm_client.py#90#24)AssistantAgent._execute_tool_callmethod, even though the tool call is valid and should be executed with empty arguments.Current Behavior
When
tool_call.arguments = "", this raises:Why are these changes needed?
Related issue number
Checks