Skip to content

fix: remove unused favicon and related references from configuration #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akhileswara-Microsoft wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −5
Open

fix: remove unused favicon and related references from configuration #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0987ce
remove unused favicon and related references from configuration
Akhileswara-Microsoft Mar 18, 2026
bdfbd17
refactor: update comment for favicon logging suppression in nginx config
Akhileswara-Microsoft Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ContentProcessorWeb/nginx-custom.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ server {
listen 80;
server_name localhost;

# Suppress nginx server logs for favicon requests
location = /favicon.ico {
return 204;
access_log off;
}

location / {
root /usr/share/nginx/html;
try_files $uri $uri/ /index.html;
Expand Down
Binary file removed src/ContentProcessorWeb/public/favicon.ico
View file
Open in desktop
Binary file not shown.
5 changes: 0 additions & 5 deletions src/ContentProcessorWeb/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="./favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta
name="theme-color"
Expand All @@ -18,8 +17,6 @@
name="description"
content="Web site created using create-react-app"
/>

<link rel="apple-touch-icon" href="%PUBLIC_URL%/favicon.ico" />
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
Expand All @@ -30,8 +27,6 @@
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>Content Processor</title>
Expand Down
Loading