Fix: Proper onClick handling for MenuGridRow#35795
Open
adamsamec wants to merge 2 commits intomicrosoft:masterfrom
Open
Fix: Proper onClick handling for MenuGridRow#35795adamsamec wants to merge 2 commits intomicrosoft:masterfrom
adamsamec wants to merge 2 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
bsunderhus
reviewed
Feb 27, 2026
| const onKeyDown = useEventCallback(mergeCallbacks(props.onKeyDown, onKeyDownToClick)); | ||
|
|
||
| const onClick = useEventCallback((event: React.MouseEvent<HTMLDivElement>) => { | ||
| if (event.target === event.currentTarget) { |
Contributor
There was a problem hiding this comment.
This is problematic @adamsamec, you can click a span inside the row and the target will differ from the current target for example. I believe we've dealt with the same issue in the TreeGrid:
https://github.com/microsoft/fluentui-contrib/blob/7d692b92cf68220593bc379866bb44dba4c37da7/packages/react-tree-grid/src/components/TreeGridRow/TreeGridRow.tsx#L69-L79
(not a great solution though...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR enables using own mouse click and Enter/spacebar key press handler on the MenuGridRow and MenuGridItem components via the onClick prop. Previously, using an onClick handler did not fire the event for Enter and spacebar presses. Pressing Enter on menu grid row instead incorrectly resulted in only moving keyboard focus to the first focusable child of the row.