feat(react-motion): add replayKey prop to replay motion without remounting#36108
Open
robertpenner wants to merge 10 commits into
Open
feat(react-motion): add replayKey prop to replay motion without remounting#36108robertpenner wants to merge 10 commits into
robertpenner wants to merge 10 commits into
Conversation
robertpenner
force-pushed
the
feat/motion-component-replay-key
branch
from
dd35075 to
0967549
Compare
robertpenner
force-pushed
the
feat/motion-component-replay-key
branch
from
0967549 to
864d814
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
robertpenner
force-pushed
the
feat/motion-component-replay-key
branch
from
68ec731 to
bc88d21
Compare
robertpenner
force-pushed
the
feat/motion-component-replay-key
branch
from
bc88d21 to
35c8ed7
Compare
…nting Add an optional replayKey prop to MotionComponentProps. When the value changes, the animation effect re-runs — cancelling any in-progress animation and replaying from the start on the same DOM element, without remounting the component or its children. Includes tests verifying both replay behaviour and DOM continuity.
… instead of recreating animations
…ing on replayKey change
…sts for callbacks and skip on replay
…ionHandle; add comments
robertpenner
force-pushed
the
feat/motion-component-replay-key
branch
from
fce9549 to
9a7dac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replayKeyprop toMotionComponentProps.onMotionStart/onMotionFinish), and skip-motion fast-forward on replay.Previous Behavior
To retrigger a motion animation on an already-mounted component, the only declarative option was to change the React
keyprop, which forces a full unmount and remount of the subtree. This destroys the DOM nodes, resets child component state, and loses focus — even when all you want is to replay the animation.New Behavior
MotionComponentaccepts an optionalreplayKeyprop (string | number). When the value changes, the animation replays from the beginning on the existing DOM element — cancelling any in-progress animation — without unmounting or remounting the component or its children. DOM continuity, focus, and child state are all preserved.Future Work