fix(android cpp): Versioned GenAI Android AAR cache to avoid old cache - #960
Open
sheetalarkadam wants to merge 3 commits into
Open
fix(android cpp): Versioned GenAI Android AAR cache to avoid old cache#960sheetalarkadam wants to merge 3 commits into
sheetalarkadam wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sheetalarkadam
force-pushed
the
fix/genai-aar-cache-staleness
branch
from
August 7, 2026 20:52
8f2547f to
83396a9
Compare
sheetalarkadam
force-pushed
the
fix/genai-aar-cache-staleness
branch
from
August 10, 2026 18:04
83396a9 to
4ee100b
Compare
sheetalarkadam
force-pushed
the
fix/genai-aar-cache-staleness
branch
from
August 10, 2026 19:43
4ee100b to
caf8783
Compare
sheetalarkadam
force-pushed
the
fix/genai-aar-cache-staleness
branch
from
August 10, 2026 19:44
caf8783 to
b126b31
Compare
sheetalarkadam
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Versions Android GenAI AAR caches and includes the required libmat.so runtime dependency.
Changes:
- Scopes downloaded and extracted AARs by GenAI version.
- Uses temporary files for safer downloads.
- Copies
libmat.sointo build outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sdk_v2/cpp/CMakeLists.txt |
Copies the GenAI libmat.so dependency. |
sdk_v2/cpp/cmake/FindOnnxRuntimeGenAI.cmake |
Adds versioned Android AAR caching and download handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sheetalarkadam
marked this pull request as ready for review
August 11, 2026 02:09
GenAI 0.15.0 split most of libonnxruntime-genai.so's implementation into a
separate libmat.so (31 MB arm64 / 30 MB x86_64), and the former now lists it
as a DT_NEEDED:
libonnxruntime-genai.so -> NEEDED libmat.so
The POST_BUILD copy only ever staged libonnxruntime-genai.so, so an Android
build produced a bin/ that cannot be loaded: libfoundry_local.so resolves
libonnxruntime-genai.so, which then fails on the missing libmat.so.
This is Android-only. GenAI ships Android as a GitHub Releases AAR, and only
that artifact is split; the Microsoft.ML.OnnxRuntimeGenAI.Foundry NuGet
package used by Windows/Linux/macOS is still monolithic and contains no
libmat at all. The copy is therefore guarded on file existence rather than on
ANDROID, which also leaves 0.14.x builds (single monolithic library, no such
dependency) working unchanged.
The Android CI staging step is updated to match, so the published artifact is
a self-contained set.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 24ef037b-246f-4fea-a1a3-4fae5223cb0c
Two independent caching defects in the Android AAR path, both of which produce a build that silently disagrees with the pinned version. Stale reuse: the archive was stored as onnxruntime-genai-android.aar and extracted to a single genai-android-aar/ directory, neither of which included the version. Both steps are guarded by EXISTS, so bumping ORT_GENAI_VERSION reused whichever AAR had been downloaded first while logging the new version. A warm build directory therefore produced binaries from the old release. CI never saw this because every run starts from a fresh binary directory; developers hit it on every bump. Scoping both the archive and the extracted tree by version makes a bump fetch its own copy. Poisoned entry: file(DOWNLOAD) writes its destination even when the transfer fails. An unpublished release returns HTTP 404, which yields status 22 and a 0-byte file. The FATAL_ERROR left that file in place, so the next configure saw EXISTS, skipped the download, and failed inside ARCHIVE_EXTRACT instead - permanently, until it was deleted by hand. Downloading to a temporary path and renaming only on success means a failed fetch leaves no cache entry. The error message now names the version and URL and points at the likely cause, since a missing Android AAR on an otherwise healthy release is the common failure. Verified: 404 leaves no cache entry and retries cleanly; 0.15.0 downloads, hits cache on re-run, and does not collide with 0.14.0; a clean Android arm64 build against the GitHub AAR links with a complete DT_NEEDED closure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 24ef037b-246f-4fea-a1a3-4fae5223cb0c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 93a7e930-97d3-4c68-832e-c449f3768cab
sheetalarkadam
force-pushed
the
fix/genai-aar-cache-staleness
branch
from
August 11, 2026 04:30
fb2078b to
e522540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Produce a build that silently disagrees with the pinned version if old file is present