CHORE: Update PR Template to auto-close tasks#275
Draft
bewithgaurav wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the PR template to include auto-closing keywords for both ADO work items and GitHub issues, enabling automatic closure when PRs are merged.
Key Changes
- Added "Closed" keyword before ADO work item references
- Added "Closes" keyword before GitHub issue references
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.build._deps.simdutf-src.src.haswell.implementation.cpp: 0.4%
mssql_python.pybind.build._deps.simdutf-src.src.implementation.cpp: 6.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.implementation.h: 10.4%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.scalar.utf16_to_utf8.utf16_to_utf8.h: 25.3%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.7%
mssql_python.pybind.build._deps.simdutf-src.include.simdutf.internal.isadetection.h: 65.3%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.2%🔗 Quick Links
|
jahnvi480
reviewed
Oct 6, 2025
jahnvi480
previously approved these changes
Oct 6, 2025
Collaborator
Author
|
Instead of closing, we should target updating the Issue with a comment saying the PR fix has been merged and this will be released in the next release cycle. And then close the issue. |
When a PR closes one or more GitHub issues and is merged into main, post a release-cycle heads-up comment on each linked issue. Closing remains driven by GitHub's native auto-close keywords in the PR template; this workflow only comments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Per the design discussion on PR #275: GitHub issues should NOT auto-close on PR merge. Maintainers close them manually after the fix actually ships in a release. ADO work items, in contrast, still auto-close immediately via the native 'Fixed AB#<id>' keyword in the PR template. - Template: drop 'Closes' from the GitHub Issue line so GitHub no longer auto-closes the issue at merge time. ADO line keeps 'Fixed AB#<id>' unchanged. - Workflow: switch from GraphQL closingIssuesReferences (which goes empty without the Closes keyword) to a body-parser that extracts issue numbers from the template's 'GitHub Issue: #<N>' line. Tolerates legacy 'Closes/Fixes/Resolves' wording and comma-separated lists. Comments never closes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
pr-size: medium
…r_template # Conflicts: # .gitignore
bewithgaurav
force-pushed
the
bewithgaurav/update_pr_template
branch
from
6b5843f to
799d99d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the pull request template to clarify how references to work items and issues should be formatted. The changes help ensure that references are properly closed when the pull request is merged.
Improvements to reference formatting:
Closed AB#<WORK_ITEM_ID>instead ofAB#<WORK_ITEM_ID>.Closes GitHub Issue: #<ISSUE_NUMBER>instead ofGitHub Issue: #<ISSUE_NUMBER>.