MfciPkg: Address PCD pointers that are not aligned. #765
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDR certificates are 4 byte aligned, but getting the PCD value does not guarantee an aligned pointer. Existing logic would align pointer, which was an issue for if the pointer was unaigned to begin with. Use align to goto the next public key, to account for unaligned pointer being returned from pcd. Brining this fix from tianocore/edk2#11529 into MFCI.
Member
|
I know this is using the PR title from the original edk2 commit, but since it is not a straight cherry-pick, I think there's a good opportunity to make it more precise to the actual change. |
apop5
changed the title
Contributor
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XDR certificates are 4 byte aligned, but getting the PCD value does not guarantee an aligned pointer. Existing logic would align pointer, which was an issue for if the pointer was unaigned to begin with.
Use align to goto the next public key, to account for unaligned pointer being returned from pcd.
Brining this fix from tianocore/edk2#11529 into MFCI.
How This Was Tested
Untested. This change is being brought from the FmpDxe, which encountered
this problem with an unaligned PCD pointer.
Integration Instructions
N/A