Conversation
Member
yury-s
commented
Mar 23, 2026
yury-s
commented
- Update driver to 1.59.0-alpha-1774052454000
- Regenerate API (new: Debugger, ConsoleMessage.timestamp, Page.consoleMessages/clearConsoleMessages/clearPageErrors/pageErrors, Page.ariaSnapshot/pickLocator/cancelPickLocator, BrowserContext.debugger/ isClosed/setStorageState, Tracing.StartOptions.live, Video.start/stop, AutoCloseable returns for addInitScript/exposeBinding/exposeFunction/route)
- Add DisposableObject/DisposableStub for AutoCloseable impls
- Fix Debugger.pausedDetails() to use local state from pausedStateChanged event
- Fix Video API: videoStart now returns artifact directly (no "video" event)
- Fix BrowserType.connect: rename wsEndpoint param to endpoint
- Port upstream tests: Debugger, ConsoleMessage timestamp/filter, clearConsoleMessages, clearPageErrors, Video.start/stop, setStorageState
- Update driver to 1.59.0-alpha-1774052454000 - Regenerate API (new: Debugger, ConsoleMessage.timestamp, Page.consoleMessages/clearConsoleMessages/clearPageErrors/pageErrors, Page.ariaSnapshot/pickLocator/cancelPickLocator, BrowserContext.debugger/ isClosed/setStorageState, Tracing.StartOptions.live, Video.start/stop, AutoCloseable returns for addInitScript/exposeBinding/exposeFunction/route) - Add DisposableObject/DisposableStub for AutoCloseable impls - Fix Debugger.pausedDetails() to use local state from pausedStateChanged event - Fix Video API: videoStart now returns artifact directly (no "video" event) - Fix BrowserType.connect: rename wsEndpoint param to endpoint - Port upstream tests: Debugger, ConsoleMessage timestamp/filter, clearConsoleMessages, clearPageErrors, Video.start/stop, setStorageState Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Port shouldSnapshotIntegration, shouldSupportMultilineText, shouldConcatenate*, shouldIncludePseudo*, shouldWorkWithSlots, shouldSnapshotInnerText, checkAriaHiddenText, shouldIgnorePresentationAndNoneRoles, shouldNotUseOnAsCheckboxValue, shouldNotReportTextareaTextContent, shouldNotShow*HiddenElements, shouldSnapshotPlaceholderWhenDifferentFromName from tests/page/page-aria-snapshot.spec.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… snapshot
- Register AriaSnapshotMode in Gson with ToLowerCaseSerializer so AI
mode is serialized as "ai" (protocol expects lowercase)
- Fix PageImpl.ariaSnapshot() to call the frame-level ariaSnapshot
protocol message directly (no selector), matching the JS client
behavior; using locator(":root") produced "document [ref=e1]" as root
in AI mode instead of the expected body-level snapshot
- Add TestPageAriaSnapshotAI with 12 tests covering: ref generation,
aria-ref locator usage, iframe listing, locator-inside-iframe,
generic node collapsing, cursor pointer hints, active element
tracking, inline generic collapsing, title preservation, depth limit
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WebKit no longer reports border-relative offsetX/offsetY, so remove the conditional isWebKit() branches. All browsers now return the same values (4c062ce upstream). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Firefox 148+ broke ontouchstart inheritance in popups (bugzilla 2014330). Matches upstream fixme added in page-popup.spec.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The JS CDPSession fires two events per CDP protocol event:
this.emit(event.method, event.params) // method-specific
this.emit('event', event) // catch-all with { method, params }
Java was only firing the method-specific one. Add the missing
listeners.notify("event", parameters) call so on("event", handler)
receives every CDP event as { method, params }.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pavelfeldman
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.