chore: extract large snapshots in the trace as resources#39765
Open
dgozman wants to merge 1 commit intomicrosoft:mainfrom
Open
chore: extract large snapshots in the trace as resources#39765dgozman wants to merge 1 commit intomicrosoft:mainfrom
dgozman wants to merge 1 commit intomicrosoft:mainfrom
Conversation
packages/playwright-core/src/server/trace/recorder/snapshotter.ts
Outdated
Show resolved
Hide resolved
pavelfeldman
approved these changes
Mar 19, 2026
Member
pavelfeldman
left a comment
pavelfeldman
left a comment
There was a problem hiding this comment.
This won't be triggered for your new snapshot, you probably want to bump the version with empty modernizer step.
if (event.version > latestVersion)
throw new TraceVersionError('The trace was created by a newer version of Playwright and is not supported by this version of the viewer. Please use latest Playwright to open the trace.');
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
chore-trace-snapshots-as-resources
branch
from
b58aee8 to
24d442e
Compare
dgozman
force-pushed
the
chore-trace-snapshots-as-resources
branch
from
24d442e to
f7eb9ca
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"5507 passed, 343 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky38815 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.