feat(cli): add --output-dir option to playwright-cli#39795
Open
178inaba wants to merge 1 commit intomicrosoft:mainfrom
Open
feat(cli): add --output-dir option to playwright-cli#39795178inaba wants to merge 1 commit intomicrosoft:mainfrom
178inaba wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--output-diroption is already available for the MCP server mode, but not for the CLI client (playwright-cli). When AI coding agents useplaywright-cliacross many repositories, snapshot files written to the default.playwright-cli/directory show up as untracked files ingit status. This PR adds--output-dirsupport toplaywright-cliso users can redirect output files (snapshots, screenshots, etc.) to a directory outside the working tree.--output-dirto the CLI client option parsing (minimist) and forward it to the daemon processconfigFromCLIOptions()--output-dirto global help output and theopencommand help schemaNote on
commands.tsquoting changeThe existing property keys in the
opencommand'soptions: z.object({})were unquoted. Adding'output-dir'(which requires quotes due to the hyphen) triggered ESLint'squote-propsconsistency rule, so all sibling keys were quoted to satisfy the linter.Fixes #39792