fix(network): remove unconditional rejectUnauthorized=false#39798
Open
yury-s wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(network): remove unconditional rejectUnauthorized=false#39798yury-s wants to merge 1 commit intomicrosoft:mainfrom
rejectUnauthorized=false#39798yury-s wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Previously, httpRequest() unconditionally set rejectUnauthorized=false when routing through an HTTPS proxy, ignoring the caller's setting. Now params.rejectUnauthorized is respected for the proxied connection.
dgozman
approved these changes
Mar 21, 2026
Contributor
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Please rename the PR to mention downloads rather than ignoreHTTPSErrors.
Also recommend NODE_TLS_REJECT_UNAUTHORIZED as a workaround?
yury-s
changed the title
rejectUnauthorized=false for downloads via proxy
yury-s
changed the title
rejectUnauthorized=false for downloads via proxyrejectUnauthorized=false
Contributor
Test results for "MCP"4 failed 5454 passed, 340 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky38817 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior can be set via
NODE_TLS_REJECT_UNAUTHORIZEDnode env variable.