Skip to content

lint: modernize __proto__ with getPrototypeOf#39919

Closed
kapouer wants to merge 1 commit intomicrosoft:mainfrom
kapouer:fix/no-proto
Closed

lint: modernize __proto__ with getPrototypeOf#39919
kapouer wants to merge 1 commit intomicrosoft:mainfrom
kapouer:fix/no-proto

Conversation

@kapouer
Copy link
Copy Markdown
Contributor

@kapouer kapouer commented Mar 28, 2026

There's an eslint setting against this, but apparently some people don't get it.
For context, see #17386.

@kapouer
Copy link
Copy Markdown
Contributor Author

kapouer commented Mar 28, 2026

@microsoft-github-policy-service agree

@pavelfeldman
Copy link
Copy Markdown
Member

You are changing the code that does not even run in Node, but is rather injected into the browser, so the issue seems unrelated.

@kapouer
Copy link
Copy Markdown
Contributor Author

kapouer commented Mar 28, 2026

Ha, so I guess it's you doing the ignore no-proto :]
Playwright fails with --disable-proto=throw, though. Maybe it's in another module ?

/home/nobody/app/node_modules/.pnpm/playwright-core@1.58.2/node_modules/playwright-core/lib/utilsBundleImpl/index.js:1
    at Module.require (node:internal/modules/cjs/loader:1556:12)
    at Object..js (node:internal/modules/cjs/loader:1943:10)
    at Module._compile (node:internal/modules/cjs/loader:1812:14)
    at Object..js (node:internal/modules/cjs/loader:1943:10)
    at Module.load (node:internal/modules/cjs/loader:1533:32)
    at Module._load (node:internal/modules/cjs/loader:1335:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at Object.get (/home/nobody/app/node_modules/.pnpm/playwright-core@1.58.2/node_modules/playwright-core/lib/utilsBundleImpl/index.js:2:838)
    at require (node:internal/modules/helpers:152:16)
    at Object.<anonymous> (/home/nobody/app/node_modules/.pnpm/playwright-core@1.58.2/node_modules/playwright-core/lib/utils.js:50:27)
    at Module._compile (node:internal/modules/cjs/loader:1812:14)
    at Object.<anonymous> (/home/nobody/app/node_modules/.pnpm/playwright-core@1.58.2/node_modules/playwright-core/lib/server/utils/expectUtils.js:103:40)
    at Module.load (node:internal/modules/cjs/loader:1533:32)
    at Module._load (node:internal/modules/cjs/loader:1335:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19) {
  code: 'ERR_PROTO_ACCESS'
}
Node.js v24.14.1
    at Gf (/home/nobody/app/node_modules/.pnpm/playwright-core@1.58.2/node_modules/playwright-core/lib/utilsBundleImpl/index.js:1:7807)
Error: Accessing Object.prototype.__proto__ has been disallowed with --disable-proto=throw

@kapouer
Copy link
Copy Markdown
Contributor Author

kapouer commented Apr 8, 2026

For context and refererence: nodejs/node#62461 loopbackio/loopback-datasource-juggler#2514
Think what you want, there was an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants