fix(test): increase Intel macOS timeout#41851
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 696f2d8a-c16c-4d90-8353-8e33d66a2c31
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' }, | ||
| }, async ({ browserType, createUserDataDir, browserName }) => { | ||
| it.fixme(browserName === 'firefox'); | ||
| it.slow(); |
There was a problem hiding this comment.
This effectively decreases timeout from 90s to 60s, maybe leave it as is?
There was a problem hiding this comment.
Good point! Turns out this was added while #41224 was causing Firefox to hang. #41309 interpreted that as two slow launches, but two days later we reverted the change and marked this test as fixme on Firefox. The .slow() stayed behind.
Of 3,338 recent executions, only one exceeded 30s: it took 79s during a failed run with 154 other timeouts. Excluding that broken run, p95 is 3.7s and the max is 17.4s. I think removing it is right - the original reason no longer applies.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 696f2d8a-c16c-4d90-8353-8e33d66a2c31
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Test results for "tests 1"1 failed 4 flaky49958 passed, 1186 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a look at the CI failures. 🟢 Both failures are pre-existing flakes — this PR is clearThe MCP run failed two DetailsPre-existing flake / infra
Assessment: the diff is confined to timeout/ Triaged by the Playwright bot - agent run |
|
Hi, I'm the Playwright bot and I took a look at the CI failures. 🟡 Two MCP failures are known flakes; one HTML-reporter failure I can't clearThe two MCP failures are well-documented pre-existing flakes. The DetailsThis PR only touches Pre-existing flake / infra
Uncertain
Assessment: nothing here points at a real regression from the timeout change. The two MCP failures are established cross-PR flakes, and the lone Triaged by the Playwright bot - agent run |
This is based on 285
mainpush runs from thetest-resultsdatabase. Intel macOS runners regularly push unrelated library tests close to the 30s timeout, so this raises their default to 60s.It also removes six
.slow()calls that are no longer needed with the new default, or whose tests consistently finish well below 30s.