-
Notifications
You must be signed in to change notification settings - Fork 289
Fix: runsettings environment variables ignored during test discovery #7078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-runsettings-ignored-data-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+291
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider and add tests Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Copilot
AI
changed the title
[WIP] Fix runsettings being ignored during test discovery
Fix: runsettings environment variables ignored during test discovery
Dec 7, 2025
Evangelink
approved these changes
Dec 7, 2025
Evangelink
approved these changes
Dec 7, 2025
Member
Evangelink
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evangelink
reviewed
Dec 7, 2025
...ns.VSTestBridge.UnitTests/TestHostControllers/RunSettingsEnvironmentVariableProviderTests.cs
Outdated
Show resolved
Hide resolved
fhnaseer
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

During test discovery for DynamicData tests, environment variables defined in
.runsettingsfiles were not available toITestDataSourceimplementations, causing tests to fail or display incorrect names in Test Explorer.RunSettingsEnvironmentVariableProvideronly checked the--settingscommand line option, ignoring environment variables used by VSTestBridge to pass runsettings configuration:TESTINGPLATFORM_EXPERIMENTAL_VSTEST_RUNSETTINGS(inline XML)TESTINGPLATFORM_VSTESTBRIDGE_RUNSETTINGS_FILE(file path)Changes
RunSettingsEnvironmentVariableProvider.IsEnabledAsync()to check environment variables in addition to command line optionExample
With
.runsettings:Environment variables are now properly set during discovery, allowing data sources to access them.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
96bvsblobprodcus338.vsblob.vsassets.io/home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.25605.2.txt(dns block)/usr/bin/dotnet dotnet build src/Platform/Microsoft.Testing.Extensions.VSTestBridge/Microsoft.Testing.Extensions.VSTestBridge.csproj --configuration Release(dns block)rcxvsblobprodcus328.vsblob.vsassets.io/usr/bin/dotnet dotnet build src/Platform/Microsoft.Testing.Extensions.VSTestBridge/Microsoft.Testing.Extensions.VSTestBridge.csproj --configuration Release(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.