remove JS exception for constructor type parameter arity match (#1434)

Author: sandersn

internal/checker/checker.go

@@ -18364,9 +18364,8 @@ func (c *Checker) getInstantiatedConstructorsForTypeArguments(t *Type, typeArgum
 
 func (c *Checker) getConstructorsForTypeArguments(t *Type, typeArgumentNodes []*ast.Node, location *ast.Node) []*Signature {
 	typeArgCount := len(typeArgumentNodes)
-	isJavaScript := ast.IsInJSFile(location)
 	return core.Filter(c.getSignaturesOfType(t, SignatureKindConstruct), func(sig *Signature) bool {
-		return isJavaScript || typeArgCount >= c.getMinTypeArgumentCount(sig.typeParameters) && typeArgCount <= len(sig.typeParameters)
+		return typeArgCount >= c.getMinTypeArgumentCount(sig.typeParameters) && typeArgCount <= len(sig.typeParameters)
 	})
 }
 

testdata/baselines/reference/conformance/jsOverrideMap.symbols

@@ -0,0 +1,13 @@
+//// [tests/cases/conformance/salsa/jsOverrideMap.ts] ////
+
+=== index.js ===
+/**
+ * @template K
+ * @template V
+ * @extends {Map<K, V>}
+ */
+export class TestMap extends Map {
+>TestMap : Symbol(TestMap, Decl(index.js, 0, 0))
+>Map : Symbol(Map, Decl(lib.es2015.collection.d.ts, --, --), Decl(lib.es2015.collection.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --))
+}
+

testdata/baselines/reference/conformance/jsOverrideMap.types

@@ -0,0 +1,13 @@
+//// [tests/cases/conformance/salsa/jsOverrideMap.ts] ////
+
+=== index.js ===
+/**
+ * @template K
+ * @template V
+ * @extends {Map<K, V>}
+ */
+export class TestMap extends Map {
+>TestMap : TestMap<K, V>
+>Map : Map<K, V>
+}
+

testdata/tests/cases/conformance/salsa/jsOverrideMap.ts

@@ -0,0 +1,12 @@
+// @allowJs: true
+// @noEmit: true
+// @checkJs: true
+// @lib: esnext,dom,dom.iterable
+// @filename: index.js
+/**
+ * @template K
+ * @template V
+ * @extends {Map<K, V>}
+ */
+export class TestMap extends Map {
+}