Convert LSP generator to mts with strip types #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the LSP generator script by converting it from JavaScript (.mjs) to TypeScript (.mts) format, utilizing Node.js's experimental strip-types feature for direct TypeScript execution.
- Converts the LSP protocol generator from JSDoc-style comments to proper TypeScript type annotations
- Updates the build pipeline to use
--experimental-strip-typesfor direct .mts execution - Configures TypeScript compiler options to support the strip-types workflow
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/lsp/lsproto/lsp_generated.go | Updates generated file header comment to reflect new .mts source |
| internal/lsp/lsproto/_generate/tsconfig.json | Adds TypeScript compiler options for strip-types compatibility |
| internal/lsp/lsproto/_generate/generate.mts | Converts from JSDoc to TypeScript syntax with proper type annotations |
| .github/workflows/ci.yml | Updates CI workflow to use strip-types for executing .mts files |
gabritto
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the lead of the other scripts we have.