refactor(http-client-java): consolidate TypeSpec mappers into base mappers#11077
Open
XiaofeiCao wants to merge 2 commits into
Open
refactor(http-client-java): consolidate TypeSpec mappers into base mappers#11077XiaofeiCao wants to merge 2 commits into
XiaofeiCao wants to merge 2 commits into
Conversation
…ppers Merge the TypeSpec-specific mappers into the shared base mappers and relocate the remaining flavor mappers/factories for a simpler, more consistent hierarchy. No change to generated output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
…ackage Relocate TypeSpecFluentNamer next to TypeSpecFluentPlugin and remove the leftover single-class fluent subpackage. Pure move, no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You can try these changes here
|
XiaofeiCao
requested review from
alzimmermsft,
haolingdong-msft and
weidongxu-microsoft
as code owners
XiaofeiCao
commented
Jun 24, 2026
Member
Author
There was a problem hiding this comment.
This file will be consolidated after JSONRPC is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the mapper class hierarchy in the Java client generator (
@typespec/http-client-java) by consolidating the TypeSpec-specific mappers into the shared base mappers, now that the generator targets the TypeSpec path.The old autorest path won't work properly after this change, and autorest is deprecated anyways.
Major changes
TypeSpec*mappers (ClientMapper,ServiceClientMapper,PrimitiveMapper,ProxyParameterMapper) into their shared base classes.http-client-generator-mgmt.TypeSpec*MapperFactorywrappers with the base flavor factories, keeping a single dedicatedAzureDataPlaneMapperFactory/AzureDataPlaneMethodGroupMapperfor the azure data-plane flavor.Out of scope
NewPluginsubclasses are intentionally left unchanged to stay aligned with downstreamautorest.java.Validation