feat(compiler): support to assign bytes for @example decorators#9277
Open
Hajime-san wants to merge 4 commits intomicrosoft:mainfrom
Open
feat(compiler): support to assign bytes for @example decorators#9277Hajime-san wants to merge 4 commits intomicrosoft:mainfrom
bytes for @example decorators#9277Hajime-san wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Hajime-san
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
Hajime-san
commented
Dec 31, 2025
| type Value, | ||
| } from "../core/types.js"; | ||
| import { getEncode, resolveEncodedName, type EncodeData } from "./decorators.js"; | ||
| import { uint8ArrayToBase64 } from "./Uint8ArrayBase64Polyfill.js"; |
Author
There was a problem hiding this comment.
If you don't want to copy and paste the polyfill, I can also install a polyfill library.
packages/compiler/lib/intrinsics.tsp
Outdated
| * const bytes = bytes.fromString("TypeSpec"); | ||
| * ``` | ||
| */ | ||
| init fromString(value: string); |
Member
There was a problem hiding this comment.
I think if we have this constructor it should be more explicit on what is the string(include the encoding)
cc @witemple-msft what do you think? this also could be a good use case for a parameterized constructor
Author
There was a problem hiding this comment.
Sorry for the late reply.
I've added the parameter of character code as the second argument. Are there any other character codes that should be supported?
microsoft-github-policy-service
bot
added
the
compiler:core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7442
Importing
examplefrom OpenAPI3 document needs this feature.