Skip to content

Comments

eng, require changelog for java client emitter#9421

Merged
weidongxu-microsoft merged 1 commit intomicrosoft:mainfrom
weidongxu-microsoft:eng_require-changelog-for-java-client-emitter
Jan 23, 2026
Merged

eng, require changelog for java client emitter#9421
weidongxu-microsoft merged 1 commit intomicrosoft:mainfrom
weidongxu-microsoft:eng_require-changelog-for-java-client-emitter

Conversation

@weidongxu-microsoft
Copy link
Contributor

Java client emitter would use the chronus to organize changelog.

@github-actions
Copy link
Contributor

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 21, 2026

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copy link
Member

@XiaofeiCao XiaofeiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always finding myself looking for chronus command..

Maybe a custom script like python?

"change:version": "pnpm chronus version --ignore-policies --only @typespec/http-client-python",
"change:add": "pnpm chronus add",

Not sure for change:add, whether we could do pnpm chronus add @typespec/http-client-java.

@weidongxu-microsoft
Copy link
Contributor Author

I'm always finding myself looking for chronus command..

Maybe a custom script like python?

"change:version": "pnpm chronus version --ignore-policies --only @typespec/http-client-python",
"change:add": "pnpm chronus add",

Not sure for change:add, whether we could do pnpm chronus add @typespec/http-client-java.

Yeah, we can certainly add that to our context, if it would be easier for human to handle.

@haolingdong-msft
Copy link
Member

LGTM. Just to clarify my understanding: this changelog is for unbranded emitter only, not for branded emitter (https://github.com/Azure/autorest.java/blob/main/typespec-extension/changelog.md), but the changes will include both branded and unbranded changes. Does my understanding correct?

@weidongxu-microsoft
Copy link
Contributor Author

Yes. The changelog is for unbranded only.

Most changes be common to both unbranded and branded (unless it only target e.g. Azure.ResourceManager tsp lib that unbranded definitely won't use).
Though, if user of unbranded won't use TCGC decorators, then it would be NOOP for them.

@weidongxu-microsoft weidongxu-microsoft added this pull request to the merge queue Jan 23, 2026
Merged via the queue into microsoft:main with commit 285584c Jan 23, 2026
26 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the eng_require-changelog-for-java-client-emitter branch January 23, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants