Make Delete Cell button reachable via arrow keys in notebook cell toolbar#320852
Draft
Copilot wants to merge 2 commits into
Draft
Make Delete Cell button reachable via arrow keys in notebook cell toolbar#320852Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…for arrow-key navigation Co-authored-by: amunger <2019016+amunger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Delete Cell button accessibility via arrow key navigation
Make Delete Cell button reachable via arrow keys in notebook cell toolbar
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notebook cell title toolbar rendered the main actions and the Delete Cell action as two separate
ToolBarinstances inside the same container. Since arrow-key navigation is scoped to a singleActionBar, keyboard users had to pressTabto move focus from the main toolbar actions onto the Delete Cell button, breaking the expected navigation pattern within a single toolbar group.Description
src/vs/workbench/contrib/notebook/browser/view/cellParts/cellToolbars.ts): Dropped the separatedeleteToolbar/createDeleteToolbarhelper and render the delete menu's actions in the existingWorkbenchToolBar, appending them after the title actions to preserve visual order.setupChangeListenersnow subscribes to bothtitleMenuanddeleteMenuchange events and recomputes the combined action list, so contributions to either menu still update correctly. The dropdown-deferred-update path is preserved.MenuId.NotebookCellTitleandMenuId.NotebookCellDeleteremain distinct, so extension contributions to either continue to work.