Claude harness no model experience#320856
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a “no models available” experience for chat sessions that require an explicit model selection (i.e. cannot fall back to Auto), with optional inline upgrade messaging for Copilot Free/EDU users. It wires this requirement through both the workbench chat model picker and the Sessions (Agents window) model picker, and adds unit tests for the new behavior.
Changes:
- Add a
requiresModelSelectioncapability to model picker delegates/options and thread it into picker item building and button labeling. - When
requiresModelSelectionis true and the model list is empty, show a disabled “No models available” entry (and an upgrade affordance for Free/EDU). - Keep the Sessions model picker visible/enabled for “requires selection but no models” sessions instead of hiding it.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Adds tests covering the new requiresModelSelection empty-models state and upgrade prompt presence/absence. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts | Extends the picker delegate interface with optional requiresModelSelection(). |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Implements the “No models available” state in buildModelPickerItems and updates the picker button label logic. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Implements requiresModelSelection() in the workbench chat picker delegate based on session type requirements. |
| src/vs/sessions/services/sessions/common/sessionsProvider.ts | Adds requiresModelSelection to ISessionModelPickerOptions so providers can opt into the required-selection behavior. |
| src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts | Sets requiresModelSelection for Claude agent-host sessions (but currently uses a provider ID check that likely won’t match real Claude provider IDs). |
| src/vs/sessions/contrib/chat/browser/modelPicker.ts | Keeps the Sessions model picker visible/enabled when a provider requires selection even if it currently offers zero models. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 3
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
dmitrivMS
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @TylerLeonhardt @sandy081