Fixes #320890 #320891
Closed
sciafri wants to merge 3 commits into
Closed
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
We don't allow contributions to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320890
Updates the resolved version of shell-quote from 1.8.3 to 1.8.4 in package-lock.json and remote/package-lock.json.
shell-quote <= 1.8.3 is affected by CVE-2026-9277 a command injection issue. The fix is resolved in shell-quote1.8.4.
shell-quote is pulled in by @vscode/sandbox-runtime (^1.8.3) in both the desktop and remote trees, and by npm-run-all2 (^1.7.3) at build time. All declared ranges already allow 1.8.4, so this is a lockfile-only change; no package.json updates are needed. The remote lockfile matters in particular since that tree ships with the server build.
How to test:
npm ls shell-quotein the repo root and inremote/reports 1.8.4 with no invalid markersnpm ciinstalls cleanly from the updated lockfilesnpm run compilesucceedsnpm run test-nodepasses - 10913 passing, 186 pending, 0 failingVerified all of the above locally on Linux.