agents: add exp settings for default agent selection#320896
Open
connor4312 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces new experimental configuration settings to control the default chat provider selection and to hide/prefer certain agent providers across the VS Code chat picker and the Agents window session type picker.
Changes:
- Adds new experimental settings for default provider selection (
chat.editor.defaultProvider) and for hiding/prefering specific providers in the editor vs Agents window pickers. - Updates the VS Code chat session-target picker to filter out hidden providers and react to the new settings.
- Updates the Agents window session type picker to filter available session types based on the new hiding/preference settings and tracks whether a stored selection was explicit vs implicit.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/constants.ts | Adds new ChatConfiguration keys and updates default session-type resolution logic. |
| src/vs/workbench/contrib/chat/browser/widget/input/sessionTargetPickerActionItem.ts | Updates editor chat picker behavior to filter/hide entries based on new settings. |
| src/vs/sessions/contrib/chat/browser/sessionTypePicker.ts | Filters Agents window session types based on new settings; extends stored preference shape. |
| src/vs/sessions/contrib/chat/browser/mobile/mobileSessionTypePicker.ts | Wires configuration service into the mobile picker subclass. |
| src/vs/platform/agentHost/common/agentHost.config.contribution.ts | Registers the new experimental configuration settings and their descriptions. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 4
4 tasks
Resolve the configured default session type for the New Chat Editor actions instead of hardcoding a local session. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts: # src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.