Skip to content

Bubble up child process errors in IndexCreationTool #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pl4nty wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Draft

Bubble up child process errors in IndexCreationTool #6261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/WinGetSourceCreator/Helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,7 @@ public static void Unpack(string package, string outDir)
string pathToSDK = SDKDetector.Instance.LatestSDKBinPath;
string makeappxExecutable = Path.Combine(pathToSDK, "makeappx.exe");
string args = $"unpack /nv /p \"{package}\" /d \"{outDir}\"";
Process p = new Process
{
StartInfo = new ProcessStartInfo(makeappxExecutable, args)
};
p.Start();
p.WaitForExit();
RunCommand(makeappxExecutable, args);
}

public static void PackWithMappingFile(string outputPackage, string mappingFile)
Expand Down Expand Up @@ -138,6 +133,11 @@ public static void RunCommand(string command, string args, string? workingDirect
}
p.Start();
p.WaitForExit();

if (p.ExitCode != 0)
{
throw new Exception($"Command failed with exit code {p.ExitCode}: {command} {args}");
}
}

// If in the future we edit more elements, this should be a nice wrapper class.
Expand Down
Loading