Fix analyze schema fallback for runtime-specific ops - #1304
Open
fangyangci wants to merge 2 commits into
Open
Conversation
Catch ONNX SchemaError during node schema lookup and reclassify as OpUnsupportedError so analyze continues and marks unknown/unsupported ops instead of failing. Also downgrade per-node OpUnsupportedError logging to debug to reduce noisy error output, and add regression coverage.
fangyangci
enabled auto-merge (squash)
August 12, 2026 12:40
Qiong Wu (qiowu) (DingmaomaoBJTU)
requested changes
Aug 13, 2026
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
The schema fallback keeps analyze running, but the current exception mapping loses the actual unsupported cause in normal results and suppresses unrelated unsupported-op diagnostics.
Map run_for_node condition-extraction exceptions to specific reasons so schema misses and generic unsupported ops are distinguishable in non-debug payloads. Add end-to-end RuntimeCheckerQuery tests asserting returned reasons for schema-miss and unsupported-op paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes