Skip to content

fix: stop GitHub release pipeline marking releases pre-release with empty notes #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timenick merged 1 commit into from
Jun 25, 2026
Merged

fix: stop GitHub release pipeline marking releases pre-release with empty notes #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion .pipelines/modelkit-release-github.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,35 @@ extends:
Write-Host "Staged GitHub release assets:"
Get-ChildItem $dst | ForEach-Object { Write-Host (" - {0} ({1:N0} bytes)" -f $_.Name, $_.Length) }

# Extract this version's CHANGELOG section into RELEASE_NOTES.md so the
# release job (a release job, with no repo checkout) can use it as the
# release body. It ships inside the GitHubReleaseAssets artifact next to
# the wheels, and is not matched by the release task's asset globs.
$changelog = "$(Build.SourcesDirectory)/CHANGELOG.md"
$notesFile = Join-Path $dst "RELEASE_NOTES.md"
if (Test-Path $changelog) {
$lines = Get-Content $changelog
$start = -1
for ($i = 0; $i -lt $lines.Count; $i++) {
if ($lines[$i] -match "^##\s+WinML CLI v$([regex]::Escape($version))\s*$") { $start = $i; break }
}
if ($start -ge 0) {
$end = $lines.Count
for ($j = $start + 1; $j -lt $lines.Count; $j++) {
if ($lines[$j] -match '^##\s') { $end = $j; break }
}
$section = if ($end -gt ($start + 1)) { $lines[($start + 1)..($end - 1)] } else { @() }
[System.IO.File]::WriteAllText($notesFile, (($section -join "`n").Trim() + "`n"))
Write-Host "Wrote release notes for v$version to $notesFile"
} else {
Write-Warning "No '## WinML CLI v$version' section in CHANGELOG.md; release notes will be empty"
[System.IO.File]::WriteAllText($notesFile, "")
}
} else {
Write-Warning "CHANGELOG.md not found at $changelog; release notes will be empty"
[System.IO.File]::WriteAllText($notesFile, "")
}

- job: CreateGitHubRelease
displayName: 'Create GitHub Release'
dependsOn: Prepare
Expand Down Expand Up @@ -118,6 +147,11 @@ extends:
Write-Host "Tag: $tag"
Write-Host "##vso[task.setvariable variable=ReleaseVersion]$version"
Write-Host "##vso[task.setvariable variable=ReleaseTag]$tag"
# A plain X.Y.Z is a real release; any PEP 440 suffix
# (e.g. 0.3.0rc1, 0.3.0.dev1, 0.3.0b1) is a pre-release.
$isPre = if ($version -match '^[0-9]+\.[0-9]+\.[0-9]+$') { 'false' } else { 'true' }
Write-Host "IsPreRelease: $isPre"
Write-Host "##vso[task.setvariable variable=IsPreRelease]$isPre"

- task: GitHubRelease@1
displayName: 'Create GitHub Release'
Expand All @@ -129,9 +163,11 @@ extends:
tagSource: userSpecifiedTag
tag: '$(ReleaseTag)'
title: 'WinML CLI $(ReleaseTag)'
releaseNotesSource: filePath
releaseNotesFilePath: '$(Build.SourcesDirectory)/release_assets/RELEASE_NOTES.md'
assets: |
$(Build.SourcesDirectory)/release_assets/*.whl
$(Build.SourcesDirectory)/release_assets/rules-v$(ReleaseVersion).zip
isDraft: false
isPreRelease: true
isPreRelease: $(IsPreRelease)
addChangeLog: false
Loading